#17578: Use Parent/Element for Manin symbols
-------------------------------------+-------------------------------------
Reporter: pbruin | Owner:
Type: defect | Status: positive_review
Priority: major | Milestone: sage-6.5
Component: modular forms | Resolution:
Keywords: Manin symbol | Merged in:
Authors: Peter Bruin, | Reviewers: Travis Scrimshaw,
Travis Scrimshaw | Peter Bruin
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/pbruin/17578-ManinSymbol_Parent_Element|
286e4756e2bb1e5657611d505ec5d7d6f99f3c36
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by pbruin):
* status: needs_review => positive_review
Comment:
Replying to [comment:16 tscrim]:
> Overall I'm happy with the changes (especially the speedup, which was
the sticking point for getting this in).
Thanks!
> Quick question, could any of those methods for the `ManinSymbol` class
be declared `cpdef` and get a speed boost? If not (or you don't think it's
necessary to do now), you can set this to a positive review.
I prefer to do this later if and when it becomes necessary.
--
Ticket URL: <http://trac.sagemath.org/ticket/17578#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
