#17840: Factorization of multivariate polynomials over the integers
-------------------------------------+-------------------------------------
Reporter: bruno | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: factorization | Resolution:
Keywords: multivariate | Merged in:
integer polynomial | Reviewers: Jeroen Demeyer
Authors: Bruno Grenet | Work issues:
Report Upstream: N/A | Commit:
Branch: | ffe8f4578766dc50cf648e94b7274dce2425318d
u/bruno/factorization_of_multivariate_polynomials_over_the_integers|
Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by bruno):
* status: needs_work => needs_review
Comment:
Replying to [comment:15 jdemeyer]:
> 1. Replace `raise Exception, "Message."` by `raise
Exception("message")`.
Done.
> 2. Is the check for integral domain really needed? If it's not an
integral domain, it will be caught by the branch below.
> 3. Why did you add the check for symbolic ring? If it's needed, there
should also be a doctest added for this case.
These both tests were not really needed. I added them in order to give
more meaningful error messages. Now, the error message for the
`SymbolicRing` is kind of weird, but the test I added was probably not the
right place where to correct this.¹ For non-integral rings, you know have
that `multivariate factorization over Ring of integers modulo 4 is not
implemented` (for instance) while with the previous version it said that
the factorization over non-integral rings is not implemented. I personally
find the previous message more informative, but that is a matter of taste
and I am also fine with the current message.
> 4. The message `Factorization of multivariate polynomials over Symbolic
Ring is not implemented. Consider using multivariate polynomial rings
instead.` is confusing, it essentially says "factorization of multivariate
polynomials is not supported, use multivariate polynomials instead".
Not relevant anymore, though I agree with the confusing aspect of this
message!
¹ The main problem is that the `SymbolicRing` has no `is_finite()` method.
Thus we get a `NotImplementedError` which is not very informative.
--
Ticket URL: <http://trac.sagemath.org/ticket/17840#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
