#18047: Add libhomfly as optional package
-------------------------------------+-------------------------------------
       Reporter:  mmarco             |        Owner:
           Type:  enhancement        |       Status:  new
       Priority:  minor              |    Milestone:  sage-6.6
      Component:  packages:          |   Resolution:
  optional                           |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:                     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  14112a4f0e85cf0e2678f958208261d76e2cc43b
  u/mmarco/libhomfly                 |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by vbraun):

 Looks good. Newer autoconf gives one warning, can you add `AM_PROG_AR` to
 fix it?
 {{{
 diff --git a/configure.ac b/configure.ac
 index 6c5f369..103e585 100644
 --- a/configure.ac
 +++ b/configure.ac
 @@ -2,8 +2,9 @@ AC_INIT([libhomfly], [1.0], [[email protected]])
  AC_CONFIG_AUX_DIR([build-aux])
  AC_CONFIG_MACRO_DIR([m4])
  AM_INIT_AUTOMAKE([foreign -Wall])
 -LT_INIT
  AC_PROG_CC
 +AM_PROG_AR
 +LT_INIT
  AC_CONFIG_FILES([Makefile lib/Makefile])
  AC_OUTPUT
 }}}
 Also, I take it you have a testcase (a minimal C program to link to your
 library to see if it works?) That would be nice to add, can save you quite
 a bit of debugging headache later.

--
Ticket URL: <http://trac.sagemath.org/ticket/18047#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to