#11565: RSA Cryptosystem
-------------------------------------+-------------------------------------
Reporter: ajeeshr | Owner: mvngu
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.6
Component: cryptography | Resolution:
Keywords: RSA, crypto, | Merged in:
public key encryption | Reviewers:
Authors: Peter Story, | Work issues:
Ajeesh Ravindran | Commit:
Report Upstream: N/A | 4b667369410afa8400b009b8f4f5cc0ad968c78c
Branch: | Stopgaps:
u/peter.story/rsa_cryptosystem |
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_work
Comment:
1. If `__init__` is empty, you can just '''avoid''' it.
2. What is the point of having the comparison implemented?! Moreover, the
way you did is completely wrong
{{{
+ if self.__repr__() == other.__repr__():
+ return True
}}}
The following will return `True`
{{{
sage: rc1 = RSACryptosystem()
sage: a = str(rc1)
sage: rc1 == a
}}}
3. In the function `encrypt` in the section `TESTS` you repeat many times
the definition of `rc` as well as the computation of the keys. Just remove
all these duplication.
--
Ticket URL: <http://trac.sagemath.org/ticket/11565#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
