#18084: Fix bad library uses of var()
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: symbolics | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers: Ralf Stephan
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/fix_bad_library_uses_if_var__|
f680be3a9f7da9ca3957a9709997a30917bba687
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jdemeyer):
* status: needs_info => needs_review
Comment:
Replying to [comment:6 kcrisman]:
> {{{#!diff
> sage: Sym =
SymmetricFunctions(FractionField(QQ['t'])).macdonald()
> Traceback (most recent call last):
> ...
> - ValueError: parameter q must be in the base ring
> + TypeError: unable to convert string
> }}}
> Is this a regression in terms of the error message, an improvement, or
just a change?
Probably all three. In any case, the code is more clear, the exception
type (`TypeError` instead of `ValueError`) is surely better. The error
message is less clear, but that's something which can be fixed independent
of this ticket.
(As a personal pet peeve, I really dislike excessive exception raising
code. Moreover, I prefer a good traceback over a good error message.)
--
Ticket URL: <http://trac.sagemath.org/ticket/18084#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
