#18075: Add inversion number method to AlternatingSignMatrices
-------------------------------------+-------------------------------------
       Reporter:  jessicapalencia    |        Owner:  jessicapalencia
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.6
      Component:  combinatorics      |   Resolution:
       Keywords:  asm, days64, aim   |    Merged in:
        Authors:  Jessica Striker    |    Reviewers:
Report Upstream:  N/A                |  Work issues:  error pointed out
         Branch:                     |  inside branch
  public/ticket/18075                |       Commit:
   Dependencies:                     |  82c96d70c29144b8523ea48fbc4d44fb06dda9ca
                                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by darij):

 Review branch uploaded.

 A few remarks:

 I am not 100% sure whether the letter ℓ goes against coding standards, but
 I have replaced it by a regular l to be safe. The docstrings are sent to
 latex, and I think latex doesn't like things that aren't ascii.

 Also removed all the trailing whitespace.

 The error in the iterator I pointed out should either be fixed here or
 moved to another ticket. Other than this, the ticket is good to go if you
 think the review changes are fine!

--
Ticket URL: <http://trac.sagemath.org/ticket/18075#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to