#18046: Graphs with multiedges and latex
-------------------------------------+-------------------------------------
Reporter: jclaas | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.6
Component: graph theory | Resolution:
Keywords: graph-theory, | Merged in:
multiedges, latex, sd66 | Reviewers:
Authors: Jacob Laas | Work issues:
Report Upstream: N/A | Commit:
Branch: | b3721b4fd42959a87ee415643a44776d2e8d83c2
u/jclaas/graphs_with_multiedges_and_latex| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_review => needs_work
* keywords: graph-theory, multiedges, latex => graph-theory, multiedges,
latex, sd66
Comment:
Hello,
Several other remarks:
- These days I have been told that we should use `isinstance(x,list)`
instead of
`type(x) in [list]`. Note that the following works:
sage: isinstance([],(list,dict))
True
sage: isinstance({},(list,dict))
True
sage: isinstance(5,(list,dict))
True
- Now, this file looks rather messy and you apparently tried to get your
code to
'fit in the local style'. It seems that they define a variable named
`number_types` that you could use.
- `et` -> no short name please.
- This line contains both `and` and `or`. Could you add parentheses where
they belong ?
{{{if self._graph.is_directed() or self._graph.allows_multiple_edges()
and not loop:}}}
- Could you write the proper documentation (in the INPUT section of the
docstring) for the parameter `edge_thickness` in
case of multiple edges?
- Your error message is misleading: it is not that multiple customization
of
multiedges is impossible, it is that only `thickness` can be set. At
least,
this is what your condition tests.
- What is the difference between `->` and `post` in TikZ? Why did you make
that
change?
- Is there any reason why you call
`self._graph.edge_label(edge[0],edge[1])`?
That value should already be equal to `e[2]`, shouldn't it?
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/18046#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
