#18067: sage/graphs/graph.py: multigraph recognition in init fails
-------------------------------------+-------------------------------------
Reporter: darij | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: graph theory | Resolution:
Keywords: graphs, sage- | Merged in:
combinat, | Reviewers:
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: public/18067 | 04470691505336f5ce54b60569354d747fe80b76
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
Hello,
> I have nowhere near the expertise required to review this, but you have
my thanks. This is a courageous and overdue step towards cleaning up the
Augean stables of Sage's constructors.
Well, this code really needs to be rewritten properly.
> is so ugly it is almost ridiculous.
+1
> Good job improving the if-condition, but IMHO the whole logic should go
to hell.
Ahahaha. Well, I also agree with you on that point, but I cannot get code
in Sage by myself. I know that I only fixed a small part of the problem in
this ticket, but doing too many things at once makes it impossible to find
a reviewer. Soooooo while I already know what the next ticket will be
about, I thought that it was better to write a smaller patch first. Then
the other will come.
> To drive the point home, maybe add a doctest with the matrix
I do not believe in adding doctests to explain that our code is bad. Let
us change the code.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/18067#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
