#18099: Prepare linear_code for inheritance
-------------------------------------+-------------------------------------
Reporter: dlucas | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: coding theory | Resolution:
Keywords: sd66 | Merged in:
Authors: David Lucas | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/dlucas/prepare_linear_code_for_inheritance|
bf70359e1dd818e8dfc066ad2efa4ea03e06144d
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
Helloooooooooooooooooooo !
Several comments:
- I do not understand why you created a specific function
`_init_linear_code`
instead of writing what you need in the `__init__` function. In
particular the
names `__init__` and `_init_linear_code` do not indicate how their aims
are
different.
- If you want to change the name of the function, could it mention
categories
explicitly? (Or is there a reason not to?)
- If you decide to remove this function, please move the doctests that
it
contains to the `__init__` method.
- You say in the ticket's description that you add a `base_ring` method
while
you implement `base_field`. What is the correct version?
- I do not understand why you implement this function while saying that it
is
'inherited'.
- If it is inherited, why do you need to implement it?
- If it is *not* inherited, then shouldn't we fix that instead of
implementing the function?
- We usually type '::' at the end of the line. Is there any reason why you
write
your code this way?
{{{
We now create a member of our newly made class
::
}}}
Note that writing `our newly made class::` will appear in the HTML as
`out
newly made class:` (only one ':'). If you do not want to see this
terminal ':'
then a space is sufficient, e.g.: `This sentence ends here. ::`
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/18099#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
