#877: [with patch, positive review] "sage -coverage" should not care about
functions which are local to other functions/methods
---------------------------+------------------------------------------------
Reporter: cwitty | Owner: jhpalmieri
Type: defect | Status: closed
Priority: minor | Milestone: sage-4.1.1
Component: documentation | Resolution: fixed
Keywords: | Reviewer: William Stein, Harald Schilly
Author: John Palmieri | Merged: Sage 4.1.1.alpha1
---------------------------+------------------------------------------------
Changes (by mvngu):
* status: assigned => closed
* reviewer: => William Stein, Harald Schilly
* resolution: => fixed
* merged: => Sage 4.1.1.alpha1
Comment:
This is what I observe regarding John's patch. In Sage 4.1 without the
patch {{{trac_877-scripts-coverage2.patch}}}, we have
{{{
Overall weighted coverage score: 77.8%
Total number of functions: 22398
}}}
Applying that patch to Sage 4.1:
{{{
Overall weighted coverage score: 78.3%
Total number of functions: 22210
}}}
If I understand John's patch correctly, it doesn't count functions which
are local to other functions/methods. This accounts for the reduced number
of total functions after applying the patch. Moving on to Sage
4.1.1.alpha0 without the patch:
{{{
Overall weighted coverage score: 78.0%
Total number of functions: 22497
}}}
And with the patch:
{{{
Overall weighted coverage score: 78.5%
Total number of functions: 22308
}}}
Here is the coverage after applying the patch to my merge tree:
{{{
Overall weighted coverage score: 78.6%
Total number of functions: 22317
}}}
[[BR]]
Merged {{{trac_877-scripts-coverage2.patch}}} in the scripts repository.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/877#comment:8>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
