#17282: Implementing Wehler K3 Surfaces
-------------------------------------+-------------------------------------
       Reporter:  jdefaria           |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.6
      Component:  algebraic          |   Resolution:
  geometry                           |    Merged in:
       Keywords:                     |    Reviewers:  Ben Hutz, Grayson
        Authors:  Joao Alberto de    |  Jorgenson
  Faria                              |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  9b268f823c0e0ff35f0b881dadaa50ca72bfe875
  u/jdefaria/ticket/17282            |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by bhutz):

 * status:  needs_review => needs_work


Comment:

 Here is the last bit, reviewing the degenerate fiber morphisms:

 sigamX:
 - 1034-35, 1047-48, 1061-62: are all exactly the same, so can be before
 the ifs

 - 1036, 1037 - switch order so that t = w1-t1 (and in the other 2 places)

 - put the T after the ifs since they are all the same

 - 1078: use .divides

 - 1076-1088: needs some comments

 - 1116 use divides

 - The whole degenerate fiber computation is badly in need of
 comments/explanation

 all the same comments for sigmaY

--
Ticket URL: <http://trac.sagemath.org/ticket/17282#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to