#12824: Delete some of the deprecated is_* functions.
-------------------------------------+-------------------------------------
Reporter: JStarx | Owner: tbd
Type: task | Status: needs_work
Priority: major | Milestone: sage-6.4
Component: misc | Resolution:
Keywords: is_functions | Merged in:
Authors: Jim Stark | Reviewers:
Report Upstream: N/A | Work issues: split patch, docs do
Branch: | not build
u/rws/delete_some_of_the_depreciated_is___functions_| Commit:
Dependencies: | 4236760f802703629e45c1084fc29468e384bf60
| Stopgaps:
-------------------------------------+-------------------------------------
Old description:
> As discussed here: [http://groups.google.com/group/sage-
> devel/browse_thread/thread/e8c2470e270f616b/c760f4a79d28f467?lnk=gst&q=is_#],
> functions of the form is_SomeName(x) are depreciated and have been for
> some time. This patch removes 106 of them and replaces them with calls
> to isinstance. The patch was created by running the attached python
> script. It searches through the source for functions of the form
>
> {{{
> def is_SomeName(x):
> """a docstring"""
> return isinstance(x, SomeName)
> }}}
>
> where SomeName is the class of a Sage object, deletes them, and replaces
> any calls with calls to isinstance. After the script ran I made sure
> sage built, passed all its tests, and I looked through the diff to make
> sure nothing silly happened.
New description:
As discussed here: [http://groups.google.com/group/sage-
devel/browse_thread/thread/e8c2470e270f616b/c760f4a79d28f467?lnk=gst&q=is_#],
functions of the form is_SomeName(x) are deprecated and have been for some
time. This patch removes 106 of them and replaces them with calls to
isinstance. The patch was created by running the attached python script.
It searches through the source for functions of the form
{{{
def is_SomeName(x):
"""a docstring"""
return isinstance(x, SomeName)
}}}
where SomeName is the class of a Sage object, deletes them, and replaces
any calls with calls to isinstance. After the script ran I made sure sage
built, passed all its tests, and I looked through the diff to make sure
nothing silly happened.
--
Comment (by jdemeyer):
You cannot just remove functions without deprecation first.
--
Ticket URL: <http://trac.sagemath.org/ticket/12824#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
