#18176: Show animation
-------------------------------------+-------------------------------------
Reporter: vbraun | Owner:
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-6.6
Component: graphics | Resolution:
Keywords: | Merged in:
Authors: Volker Braun | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vbraun/show_animation | 39263a4fc8c59879373a47d55a9040a5d6702de9
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by gagern):
Replying to [comment:10 vbraun]:
> I tried to preserve the delay parameter, but then I don't even know what
its supposed to mean.
The doc says correctly:
* delay between frames (measured in hundredths of a second, default value
20)
* (default: 20) delay in hundredths of a second between frames
This is used throughout the public Animation class. You might argue that
it's a suboptimal choice, but it's what the GIF spec uses, what most
animated GIF editors use, and what Sage has been using so far.
> Sometimes its the numerator of some fraction (with a separate
`delay_denominator`. Sometimes its centiseconds, because thats super-
convenient right. Never mind why you would ever pass a fraction as
separate numerator/denominator in Sage.
That's in the APngAssembler I wrote, and it's there that way because I
consider the APngAssembler a low-level interface, and the low level spec
of APNG uses that representation for rational numbers. I saw no reason to
complicate things further by introducing my own translation layer, and I
didn't consider `delay_denominator` harmful enough to fix it at 100
instead of leaving the caller an option to override this.
> IMHO it should be the reciprocal anyways, fps = frames per second. That
is much more common when talking about animation speeds.
For movies, yes. For animated GIFs, in my experience no. I wouldn't mind
having `fps` as an ''additional'' argument, so users can choose between
specifying that or `delay`. But I'd not kill off the `delay` argument
without proper deprecation. And don't you dare call this spacebar heating!
--
Ticket URL: <http://trac.sagemath.org/ticket/18176#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
