#16477: implement Dirichlet series
-------------------------------------+-------------------------------------
Reporter: rws | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.6
Component: number theory | Resolution:
Keywords: moebius, zeta, | Merged in:
sigma, euler_phi, euler | Reviewers:
Authors: Jonathan Hanke, | Work issues: documentation,
Ralf Stephan | elementary operations
Report Upstream: N/A | Commit:
Branch: u/rws/16477-1 | c595740c4b6e92da37f2ed90579f4a3f5664923b
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_work
* work_issues: => documentation, elementary operations
Comment:
Hello,
6 more questions/issues.
7. Why are you importing the alias `dirichlet_series` and not
`DirichletSeries` in the global namespace?
8. How do I get the coefficients of the Dirichlet L functions obtained
with the command `dirichlet_L(3,2,s)`?
9. There are several issues with the documentation:
- you forgot `::` at line 107 (in `DirichletSeries` class documentation).
- the `INPUT` block does not follow the convention (see the developer
guide, section Documentation String)
- doctests are missing from many important functions (e.g. `base_ring`,
`is_Eulerian`, `has_infinite_precision`, `list`)
10. In `__mul__` I do not understand
{{{
R = self.base_ring()
try:
_ = RR(other)
}}}
Did you want to write `R(other)`? If so it is very wrong since if you
multiply `2.0` with a Dirichlet serie with rational coefficients you would
end up with rational coefficients as
{{{
sage: QQ(3.2314)
16157/5000
}}}
You should really use coercion here (i.e. the item 4 in [comment:38
comment:38]) or do stronger type check such as {{{parent(other) is
self.base_ring()}}}.
11. This should work
{{{
sage: D1 = dirichlet_series([1,1,1])
sage: D1 + 1
Traceback (most recent call last):
...
}}}
(also related to item 4 in [comment:38 comment:38]).
12. What is the purpose of this nested `MaskFunction` class?
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/16477#comment:52>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
