#18187: Move the planarity files to a spkg
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.6
Component: packages: | Resolution:
standard | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: public/18187 | 4f8f33dce644b511d120a88b98e779476d895a53
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jdemeyer):
* status: needs_review => needs_work
Comment:
Is this meant to be a standard or optional package? In any case, the
current branch obviously doesn't work if `planarity` is not installed:
{{{
$ make
...
building 'sage.graphs.planarity' extension
Executing 1 command (using 1 thread)
gcc -fno-strict-aliasing -g -O2 -DNDEBUG -g -fwrapv -O3 -Wall -fPIC
-I/usr/local/src/sage-config/local/include -I/usr/local/src/sage-
config/src -I/usr/local/src/sage-config/src/c_lib/include -I/usr/local/src
/sage-config/src/sage/ext -I/usr/local/src/sage-
config/local/include/python2.7 -c build/cythonized/sage/graphs/planarity.c
-o build/temp.linux-x86_64-2.7/build/cythonized/sage/graphs/planarity.o
-fno-strict-aliasing -w -fno-tree-dominator-opts
build/cythonized/sage/graphs/planarity.c:276:29: fatal error:
planarity/graph.h: No such file or directory
#include "planarity/graph.h"
^
compilation terminated.
error: command 'gcc' failed with exit status 1
Makefile:19: recipe for target 'build' failed
make: *** [build] Error 1
}}}
Also: to be safe, you might want to rebase on top of #18145, especially if
you make further changes to the build system.
--
Ticket URL: <http://trac.sagemath.org/ticket/18187#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
