#18213: A lot of polytopes constructor are broken
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.7
Component: geometry | Resolution:
Keywords: | Merged in:
Authors: Vincent Delecroix | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/18213 | eef42afa3e3229534f2ae2d3303fbb176eaecdd8
Dependencies: #18211 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Replying to [comment:12 vdelecroix]:
> Replying to [comment:11 jdemeyer]:
> > The `golden_ratio()` can obviously be defined in terms of `sqrt(5)`,
so I don't see the need for that. I'm also really wondering whether you
need the custom `sqrt()` function, doesn't `QuadraticField(n)` work?
>
> Right. The problem of embedding should be done elsewhere (my version
embedds in `QQbar` whereas the generic `QuadraticField(n)` embedds into
`RLF`).
Here is one reason. The generator name of `QuadraticField(2)` is `a` and
it better be `sqrt2` in this case. For the golden ratio, the advantage is
that its get printed as `phi`. In particular you have
{{{
sage: polytopes.icosahedron().volume()
5/6*phi + 5/6
}}}
The answer `5/6*a + 5/6` would have been terrible here. I have nothing
against using `phi = (sqrt5+1)/2`. So I will at least remove this one. For
the quadratic fields, one option is to globally make this change in
another ticket. What do you think?
--
Ticket URL: <http://trac.sagemath.org/ticket/18213#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
