#18157: Random failure in coerce_action.pyx
-------------------------+-------------------------------------------------
Reporter: | Owner:
vbraun | Status: needs_work
Type: | Milestone: sage-6.6
defect | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Simon King
coercion | Work issues: Find underlying problem for
Keywords: | elliptic curve problem, or open a new ticket
random_fail | for it
Authors: | Commit:
Report Upstream: N/A | ced7bfcc760e2fb362b2a382a22a94e02f996f9b
Branch: | Stopgaps:
public/18157 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by SimonKing):
* status: needs_review => needs_work
* reviewer: => Simon King
* work_issues: =>
Find underlying problem for elliptic curve problem, or open a new
ticket for it
Comment:
With one exception, the flaky tests constitute a misuse: Objects that are
normally used internally are suddenly put out into the wild. It is clear
that that can lead to disaster unless precautions are taken. Hence, I
support the general approach in the attached branch: In these tests, one
should work with permanent rather than temporary objects, to prevent
premature garbage collection.
However, one should also explicitly say in these tests that we are talking
about things that normally happen in the innards of Sage, and that the
tests do ''not'' show how to work with them!
One test is different:
{{{
#!diff
@@ -606,7 +624,8 @@ cdef class IntegerMulAction(Action):
This used to hang before :trac:`17844`::
- sage: E = EllipticCurve(GF(5), [4,0])
+ sage: GF5 = GF(5)
+ sage: E = EllipticCurve(GF5, [4,0])
sage: P = E.random_element()
sage: (-2^63)*P
(0 : 1 : 0)
}}}
Defining an elliptic curve over a finite field should certainly be enough
to prevent the finite field from garbage collection! So, here I do not
agree with the fix. Apparently the test fails because of an internal bug,
not because of misuse.
So, I put it to "needs work", because we should either find and fix the
underlying bug here, or open a new ticket for the elliptic curve issue.
--
Ticket URL: <http://trac.sagemath.org/ticket/18157#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
