#18231: constructing matrices is very slow
-------------------------------------+-------------------------------------
       Reporter:  vdelecroix         |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.7
      Component:  linear algebra     |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Vincent Delecroix  |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/vdelecroix/18231                 |  c1c7034ed54c7493a7fedbf6fa9798f23946902c
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Vincent Delecroix', 'oldvalue': ''}):

 * status:  new => needs_review
 * commit:   => c1c7034ed54c7493a7fedbf6fa9798f23946902c
 * branch:   => u/vdelecroix/18231
 * author:   => Vincent Delecroix


Comment:

 I only did some cleanup in `matrix_space.py` and
 `matrix_generic_dense.pyx`. And there is a substantial gain in speed! The
 tiny modification in #18213 to `NumberField.__cmp__` actually makes a much
 bigger difference.

 I did not solve the problem of the matrix space being rebuilt every time.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=f6a87ed8ba412a58a9c8dd582ac716ac968fcf1b
 f6a87ed]||{{{Trac 18231: better code in matrices}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=d834354d719c55a88018c8c7bb0d6ab94542d771
 d834354]||{{{Trac 18231: move _get_matrix_class out of the class}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=d52a63da8ae80bb9be6d5e401568bb4cf4baef6c
 d52a63d]||{{{Trac 18231: constructor + __matrix_class ->
 _matrix_class}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=ecd6e2743f973b05632edc688bd7a99c68e22ab8
 ecd6e27]||{{{Trac 18231: removed unused import}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=a23d09c1d4420f0bef8271785225bd12d4ad05c1
 a23d09c]||{{{Trac 18231: get rid of a one year old deprecation}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=6e9aab1a94f9df0cdca30ba026639d48b550e24c
 6e9aab1]||{{{Trac 18231: remove a useless function}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=95c9dfe9d827b2b83bfa2eb76fcb5b44eb6726f3
 95c9dfe]||{{{Trac 18231: set .__call__() as an alias of .matrix()}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=6dbf25e277f2e73c6a917c4d41872e370f65d56f
 6dbf25e]||{{{Trac 18231: rewrite .matrix()}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=c1c7034ed54c7493a7fedbf6fa9798f23946902c
 c1c7034]||{{{Trac 18231: fix dict_to_list}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/18231#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to