#18003: Implement Fully Packed Loop class
-------------------------------------+-------------------------------------
       Reporter:  kdilks             |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.6
      Component:  combinatorics      |   Resolution:
       Keywords:  fpl, ncp, days64,  |    Merged in:
  asm, lp, fully packed loop         |    Reviewers:  Jessica Striker,
        Authors:  James Campbell,    |  Travis Scrimshaw
  Vince Knight, Jessica Striker,     |  Work issues:  create a parent class
  Kevin Dilks, Emily Gunawan         |       Commit:
Report Upstream:  N/A                |  cc75caeaf1819cd8e27e88c5ba003fb4c3d57cf8
         Branch:                     |     Stopgaps:
  public/ticket/18003                |
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by tscrim):

 * status:  needs_review => needs_work
 * work_issues:   => create a parent class


Comment:

 Something else to change would be to make `self._six_vertex_model` (add
 the underscore) and then access it via a method so the FPL class acts as
 immutable. I'm also not happy with comparing equality by the repr's. I
 think it would be better to compare the underlying 6 vertex models. Also
 you should consider implementing a `__ne__` method as well.

 I also believe we should not merge this ticket without a corresponding
 parent class. The basic framework would be
 {{{#!python
 class FullyPackedLoops(Parent, UniqueRepresentation):
     def __init__(self, n):
         self._n = n
         Parent.__init__(self, category=FiniteEnumeratedSets())

     def __iter__(self):
         for X in SixVertexModel(self._n):
             yield self.element_class(self, X)

     Element = FullyPackedLoops
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/18003#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to