#18187: Move the planarity files to a spkg
-------------------------------------+-------------------------------------
       Reporter:  ncohen             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.7
      Component:  packages:          |   Resolution:
  standard                           |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Nathann Cohen      |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  public/18187       |  d3692c1cd9b02e07c1433daca6a6ad8a605f47df
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):

 * status:  needs_work => needs_review


Comment:

 Helloooooo,

 > Well, the spkg is still not built by default (see `build/deps` and
 `build/install`).

 Right! Fixed.

 > Did you report your changes upstream?

 No I didn't, and for two reasons:
 1) What we have in Sage is apparently an old version of the files. When
 building the first version of this package (without autotools) I tried to
 use the new ones, but did not figure out how they should be compiled.

 2) The makefiles this archive contains are only made to build everything
 as a shared library, while upstream also builds an independent executable
 and maybe some other things. They probably wouldn't like what I wrote.

 I plan to do both, however, and I will start by sending them an email to
 ask whether they would accept such a pull request. Then I will try to
 figure out how to make it all work properly, and we will update our
 version of this package.

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/18187#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to