#17890: Remove _(rich)cmp_c_impl
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.7
Component: cython | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/ticket/17890 | 0d1e049f807a1c34b00cf0e58ee65cc7734d1ad1
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jdemeyer):
* status: needs_info => needs_review
* milestone: sage-6.6 => sage-6.7
Comment:
OK, I made some further changes to `_richcmp`. There is one important
functional change: when comparing two elements of the same type but
different parents such that no coercion is possible (e.g. vectors over a
different finite field), comparison is done by `id` instead of always
returning `True` for `__lt__`:
before:
{{{
sage: v = vector(GF(5), [1])
sage: w = vector(GF(7), [1])
sage: v < w
True
sage: w < v
True
}}}
after, `id(v)` and `id(w)` are compared.
This caused some doctest failures, which I simply removed (there was not
much point in those tests). I also discovered #18308 this way (where there
should be a coercion, but there isn't).
--
Ticket URL: <http://trac.sagemath.org/ticket/17890#comment:54>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
