#18247: MPIR's configure fails with GCC 5.x
-------------------------------------+-------------------------------------
Reporter: leif | Owner:
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-6.7
Component: packages: | Resolution:
standard | Merged in:
Keywords: GNUC STDC | Reviewers:
__inline__ | Work issues:
Authors: Leif Leonhardy | Commit:
Report Upstream: Completely fixed; | 764ad4e2462639dfb2a6d105004d9b19cf907e26
Fix reported upstream | Stopgaps:
Branch: |
u/leif/MPIR_configure_GCC_5.x |
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by leif):
* status: needs_info => needs_review
Comment:
Replying to [comment:12 jdemeyer]:
> On the other hand, with `static __inline__` I will be more at ease
regarding other (non-GCC) compilers. Here, you are fixing the test just
for GCC but what about other compilers with potentially the same problem?
Bike-shedding?
This test is solely for GCC. Other compilers may pretend they're GCC, but
then they should also define the respective macros. (We explicitly
exclude `clang`, we could in principle exclude ICC as well, but that's
something upstream should eventually decide, and not at all an issue for
Sage. I'm not aware of any other relevant compiler identifying as GCC.)
Feel free to submit some other patch upstream.
--
Ticket URL: <http://trac.sagemath.org/ticket/18247#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
