#15486: Speed up NumberField_generic.zeta() and DirichletGroup()
-------------------------------------+-------------------------------------
Reporter: elarson3 | Owner:
Type: defect | Status: positive_review
Priority: major | Milestone: sage-6.4
Component: modular forms | Resolution:
Keywords: roots of unity | Merged in:
dirichlet group | Reviewers: Frédéric Chapoton
Authors: Peter Bruin | Work issues:
Report Upstream: N/A | Commit:
Branch: | 0bbfc15be4a05287814e0a6068a547549ab96587
u/pbruin/15486-roots_of_unity | Stopgaps:
Dependencies: #15898, #15767 |
-------------------------------------+-------------------------------------
Changes (by chapoton):
* status: needs_review => positive_review
* reviewer: => Frédéric Chapoton
Comment:
As far as I can tell, this looks good. Disclaimer: I am not a number
theorist.
All tests pass, the patchbot is happy, the NewForms test takes 3s.
I was worrying about some eventual regressions in timings.
But I have not been able to find any.
Let me put this in positive review.
--
Ticket URL: <http://trac.sagemath.org/ticket/15486#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
