#18346: Easier handling of vertex labels in graph backends
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-6.7
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers:
theory | Work issues:
Keywords: | Commit:
Authors: | c626eec1f23ab4f1529efe1efa3f738b30589b74
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
public/18346 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by ncohen):
Yo !
> Actually you do since `get_vertex` or `vertex_label` are intensively
used everywhere. And those methods do check if their argument belongs to
some dictionary as a first step!
Oh really? But perhaps the dictionary does *not* contain the integers
then? Anyway, does not matter much.
> But if I understand well, the aim of the ticket is precisely '''not'''
to upgrade these two methods but just to move them.
The aim of this ticket is to merge CGraph and Backend together. All that
"backend" does is forward everything to CGraph. But I certainly cannot do
all of this at once, it would be impossible to review. Plus because of the
problems I met when writing this branch, I know that I should be wary of
the isomorphism test code which works at a lower level than I expected.
> Hum
> {{{#!diff
> + cdef int get_vertex(self, object u) except ? -2
> + cdef object vertex_label(self, int u_int)
> }}}
Fixed. Actually, those are the lines that I moved from functions to
methods. You will find (almost) the same lines with a '-' in front of
them, a couple of lines above.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/18346#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
