#4606: elliptic curves -- implement gross-Zagier L-functions
-------------------------------------+-------------------------------------
       Reporter:  robertwb           |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.7
      Component:  elliptic curves    |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  William Stein,     |    Reviewers:
  Robert Bradshaw, Craig Citro       |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  u/chapoton/4606    |  0bb47fa2466dbc64485237c788b964e5b0280ccb
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by cremona):

 Replying to [comment:33 chapoton]:
 > I see some remaining things that should be done:
 >
 > - maybe use the generic theta function code if it is faster than the one
 provided here for binary quadratic forms (as it seems to be)

 Surely such a possible improvement can be noted for later work, and not
 delay this?

 >
 > - make sure that the syntax is similar to the other L-functions we have

 Good point.

 >
 > - test with many curves and many quadratic number fields
 >

 I tested with one curve and many fields.  This led to the one suggestion I
 have:

 - somewhere, perhaps in the constructor for GrossZagierLseries, test that
 the ideal class is associated to an imaginary quadratic field.  If you
 construct it from an ideal in a real quadratic field there is a resulting
 error in the quadratic forms code, and this should be more graceful.

 John

 > - have an expert say something about the conductor. I changed it using
 my very small understanding of Dokchister parameters and it worked. But I
 am not very sure if it is the right answer for all curves and all fields.

--
Ticket URL: <http://trac.sagemath.org/ticket/4606#comment:34>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to