#15753: Add BasisExchangeMatroid.isomorphism()
-------------------------------------+-------------------------------------
Reporter: Rudi | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.4
Component: matroid theory | Resolution:
Keywords: | Merged in:
Authors: Rudi Pendavingh | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/Rudi/ticket/15753 | 3173b33f49757e8e4d247e0aebe618fa744a0ded
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by Stefan):
Two minor comments and a question:
* In BasisExchangeMatroid._is_isomorphic you changed four lines in the
EXAMPLES section to remove BasisMatroid conversions. While today that
doesn't matter, I would prefer to keep those to ensure that this file's
version of the isomorphism test gets used, instead of some subclass's
file.
* In Matroid._isomorphism you didn't indent the EXAMPLES block.
Fix those two things and the code gets a positive review from me.
One remark though: in Sage's graph class, there is a fairly common idiom
to have an option in the test methods of the form
`certificate=True/False`. When set to True, the function returns `(True,
f)` if an isomorphism f is found, and `(False, )` otherwise. I'm not
saying we should follow this here (isomorphism is important enough to be
its own function), but we may want to consider it for other test methods.
--
Ticket URL: <http://trac.sagemath.org/ticket/15753#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
