#18321: Don't cimport type
-------------------------------------+-------------------------------------
       Reporter:  jdemeyer           |        Owner:
           Type:  defect             |       Status:  positive_review
       Priority:  critical           |    Milestone:  sage-6.7
      Component:  cython             |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jeroen Demeyer     |    Reviewers:  Peter Bruin
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jdemeyer/don_t_cimport_type      |  459908c735873b7a4d65c773025cb1c931c3917e
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by pbruin):

 * status:  needs_review => positive_review


Comment:

 Replying to [comment:5 jdemeyer]:
 > Replying to [comment:3 pbruin]:
 > > What is the reason for still doing `cimport type as pytype` in
 `stdsage.pxd`?
 > No idea. It must have been needed at some point, but maybe some Cython
 upgrade changed this?
 Who knows.  The other occurrence (in `classcall_metaclass.pyx`) does seem
 to be necessary; without it, there is a doctest that crashes Sage due to
 insufficient type checking.

--
Ticket URL: <http://trac.sagemath.org/ticket/18321#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to