#18388: Optimize ManinSymbol
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.7
Component: cython | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers: Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/fix_comparison_for_maninsymbol|
07ad5881932aba2b557bfa77886d93ea3a2b4a92
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* reviewer: => Travis Scrimshaw
Comment:
Very minor point, but you could do the alignment:
{{{#!diff
- return self.__class__(self.parent(),
- (self.i,
- matrix[0]*self.u + matrix[2]*self.v,
- matrix[1]*self.u + matrix[3]*self.v))
+ return type(self)(self.parent(),
+ (self.i,
+ matrix[0]*self.u + matrix[2]*self.v,
+ matrix[1]*self.u + matrix[3]*self.v))
}}}
After that, you can set a positive review on my behalf.
--
Ticket URL: <http://trac.sagemath.org/ticket/18388#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
