#18305: Element comparison for Python classes
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.7
Component: coercion | Resolution:
Keywords: | Merged in:
Authors: Vincent Delecroix | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/18305 | 0259eb7814ac159722db566fcd52c21e040cb233
Dependencies: #18322 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jdemeyer):
I think having both `py_rich_to_bool_sgn` and `py_rich_to_bool` in Python
is overkill. Since these are Python functions anyway, the overhead of the
`_sgn` variant can be ignored.
And I don't like most of your comment changes to
`src/sage/structure/element.pyx`: if you implement just `_richcmp_`, then
you don't need `__cmp__`, not even for `cmp()`. Why did you remove {{{or
if that gives better performance}}}. And the {{{and are not identical
(i.e. self is not other).}}} addition is also wrong I think.
--
Ticket URL: <http://trac.sagemath.org/ticket/18305#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
