#17487: Poset: is_slender needs checking
-------------------------------------+-------------------------------------
       Reporter:  jmantysalo         |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  minor              |    Milestone:  sage-6.8
      Component:  combinatorics      |   Resolution:
       Keywords:  poset              |    Merged in:
        Authors:                     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jmantysalo/poset__is_slender_needs_checking|  
9a0a40e4bce164d02a09b143229ade7f37b4d3da
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jmantysalo):

 * status:  new => needs_review
 * cc: chapoton, aschilling (added)
 * priority:  major => minor
 * milestone:  sage-wishlist => sage-6.8
 * commit:   => 9a0a40e4bce164d02a09b143229ade7f37b4d3da


Old description:

> Documentation for `is_slender()` says "It is assumed for this method that
> self is a finite graded poset.
>
> 1) Does this really meens "ranked", not "graded"?
> 2) What if not? Should it raise an exception? If not, it should be
> documented what happens then.

New description:

 Documentation for `is_slender()` says "It is assumed for this method that
 self is a finite graded poset.

 What if not? Should it raise an exception? If not, it should be documented
 what happens then.

--

Comment:

 I think that either we document what the function does for non-graded
 poset, or raise an exception. This is suggestion of first type.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=9a0a40e4bce164d02a09b143229ade7f37b4d3da
 9a0a40e]||{{{Added an explanation for non-graded posets to
 documentation.}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/17487#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to