#17869: prove_BSD for elliptic curve uses an incorrect lemma
-------------------------------------+-------------------------------------
Reporter: wuthrich | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: elliptic curves | Resolution:
Keywords: BSD | Merged in:
Authors: Chris Wuthrich | Reviewers: Peter Bruin
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/wuthrich/ticket/17869 | 8b6a73af07a1c0829a09133a0af9fcef1b724eee
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by pbruin):
* reviewer: => Peter Bruin
Comment:
A few questions/comments:
- Could you add a reference to your preprint to the documentation?
- It would probably be faster to do the check for irreducible
representations after the checks for the cases `p > 11 or p == 7` and `p
== 1`.
- It seems to me that the code
{{{
phis = [phi for phi in flatten(BSD.curve.isogeny_class().isogenies())
if phi != 0 and
phi.degree() == p and
phi.domain().is_isomorphic(BSD.curve) ]
}}}
can be simplified to
{{{
phis = BSD.curve.isogenies_prime_degree(p)
}}}
Would this be OK?
- A typographical question: are the spaces around the dash in "Lawson -
Wuthrich" intentional? It is fine with me either way, but there is
already "Stein-Wuthrich" without the spaces.
--
Ticket URL: <http://trac.sagemath.org/ticket/17869#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
