#18540: Make DirichletGroup a new-style parent
-------------------------------------+-------------------------------------
Reporter: pbruin | Owner:
Type: task | Status: needs_review
Priority: major | Milestone: sage-6.8
Component: modular forms | Resolution:
Keywords: Dirichlet group | Merged in:
Authors: Peter Bruin | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/pbruin/18540-DirichletGroup_Parent|
b92b5b00d366e547a862a857783470a9e2ac71c6
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by pbruin):
Replying to [comment:5 tscrim]:
> A couple of comments:
>
> - Is `Groups().Commutative()` the best category? The `list` function
seems like they should be in finite groups and that they are is finitely
generated. I would say the category should be
`Groups().Commutative().Finite().FinitelyGenerated()` (or at least a join
with `EnumeratedSets`).
Done, but only if we know that the group of ''n''-th roots of unity in the
base ring is finite. This is currently still the case for all Dirichlet
groups that we can construct, but in the future we may admit base rings
where this is not the case (the profinite completion of '''Z''', for
example).
> - While I doubt it was used, the `__cmp__` did put a total ordering on
the parents which I think we should keep by implementing a `__lt__` (and
using `@total_ordering`).
I don't like this very much. First, the previous implementation actually
does not make sense since it depends on a total ordering of all rings.
Second, I cannot imagine why one would like to totally order all Dirichlet
groups over all rings.
--
Ticket URL: <http://trac.sagemath.org/ticket/18540#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
