#17818: Interface to FindStat
-------------------------------------+-------------------------------------
Reporter: mantepse | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.7
Component: interfaces | Resolution:
Keywords: FindStat | Merged in:
Authors: Martin Rubey | Reviewers: Christian Stump,
Report Upstream: N/A | Viviane Pons
Branch: public/findstat- | Work issues:
interface | Commit:
Dependencies: | 800182391f9e34662f8f8b8fbfde275eb5390468
| Stopgaps:
-------------------------------------+-------------------------------------
Comment (by mantepse):
Wow, great!
Because of lack of a computer I cannot really test your changes, so please
forgive if I could answer the following questions myself:
* does it really make sense to make the class `FindStat` inherit from
`SageObject`? I thought the rule was for classes with "mathematical"
objects, or at least objects the user can actually manipulate or inspect.
The reason I did not use it was that the class `FindStat` actually should
not produce any objects...
* I think I recall that in `__eq__`
{{{
if (not isinstance(other, FindStatStatistic)):
return False
}}}
is actually unnecessary - but I'm not sure. Could you please double-
check? (same for `FindStatMap`)
In any case: yes, I'm very happy with having this finished!
Thank you so much!
Martin
--
Ticket URL: <http://trac.sagemath.org/ticket/17818#comment:92>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
