#18063: Add random generation to Gelfand-Tsetlin triangles
-------------------------------------+-------------------------------------
Reporter: deinst | Owner: deinst
Type: enhancement | Status: positive_review
Priority: minor | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: David Einstein | Reviewers: kdilks
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/kdilks/random_gelfand_tsetlin | 8ad564c0e6c6457c7d0e73b6a9365255814c3c24
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by deinst):
* status: needs_review => positive_review
Comment:
It looks good to me. Thank you very much for looking at this.
Replying to [comment:12 kdilks]:
> 1) Doc-build yelled at me for trying to add a reference that was already
included somewhere else, so I guess you were right to leave it out. I may
still tweak the documentation a little, so that the mention of Propp's
algorithm and the fact that it gives a uniformly random Gelfand-Tsetlin
pattern is also attached to random_element() so it shows up in the built
reference documents, not just attached to a helper method you can only see
in the source code.
The documentation system baffles me. I am continually irked by the fact
that I need to `make doc-clean` almost every time I `make`. I think it
has to do with cross file links, but I'm generally baffled.
>
> 2) The algorithm will loop indefinitely if self is empty, so it now
raises an error if your input has a combination of k,n,and strict that
will yield no Gelfand-Tsetlin patterns (k<0 if not strict, k+1<n if
strict).
Doh! That is embarassing, I think I try to check the corner cases, but I
do things like this :(.
>
> 3) random_element() now returns a 'Gelfand-Tsetlin pattern' (in the sage
data type sense), rather than just the underlying list of lists.
That makes sense
>
Your code and documentation looks great, an improvement, and still
generates uniformly.
> I'm ok with a positive review, pending you checking my modifications.
I'm setting it to positive_review. Hopefully that is the correct
protocol.
--
Ticket URL: <http://trac.sagemath.org/ticket/18063#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
