#18448: Add test if a matroid is binary
-------------------------------------+-------------------------------------
Reporter: Rudi | Owner: Rudi
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.8
Component: matroid theory | Resolution:
Keywords: | Merged in:
Authors: Rudi Pendavingh | Reviewers: Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/tscrim/binary_matroid-18448 | ada67429271b6cee84b18067de07648e3116ab55
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* status: needs_work => needs_review
* commit: 8967234d47bf16e9bc2d5fbc26d54da72c6bf5b4 =>
ada67429271b6cee84b18067de07648e3116ab55
* branch: u/Rudi/add_test_if_a_matroid_is_binary =>
u/tscrim/binary_matroid-18448
Comment:
Another problem was that there was an item that was misaligned.
I made `local_binary_matroid` into a public function since it seems to be
more useful than a simple helper function. I also moved the import into
the function since it was circular and I couldn't get the doc to build
otherwise.
Can you check that the doc also builds for you too? If so, and you agree
with my changes, then we can set this back to positive review.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=29e84da8eaed7025cd66afa812a2de4aeb6cf47a
29e84da]||{{{Merge branch 'u/Rudi/add_test_if_a_matroid_is_binary' of
trac.sagemath.org:sage into u/Rudi/add_test_if_a_matroid_is_binary}}}||
||[http://git.sagemath.org/sage.git/commit/?id=ada67429271b6cee84b18067de07648e3116ab55
ada6742]||{{{Some changes, tweaks, and made a method public.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/18448#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
