#18637: Fix some optional/not tested tags
-------------------------------------+-------------------------------------
       Reporter:  jdemeyer           |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  minor              |    Milestone:  sage-6.8
      Component:  doctest coverage   |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jeroen Demeyer     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jdemeyer/ticket/18637            |  23736ea85fa50142a3e1fd3fe7ca4c0ce34669f5
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by jhpalmieri):

 A few tests marked `ImageMagick` fail. Should we fix them here or
 elsewhere? These changes work for me:
 {{{
 #!diff
 diff --git a/src/sage/misc/latex.py b/src/sage/misc/latex.py
 index ef76d09..6b47e20 100644
 --- a/src/sage/misc/latex.py
 +++ b/src/sage/misc/latex.py
 @@ -1084,7 +1084,7 @@ class Latex(LatexCall):
              An error
              ...
              No pages of output.
 -            <BLANKLINE>
 +            ...
          """
          MACROS = latex_extra_preamble()

 diff --git a/src/sage/plot/animate.py b/src/sage/plot/animate.py
 index 83cb499..005dcde 100644
 --- a/src/sage/plot/animate.py
 +++ b/src/sage/plot/animate.py
 @@ -118,7 +118,7 @@ import struct
  import zlib

  from sage.structure.sage_object import SageObject
 -from sage.misc.temporary_file import tmp_dir, tmp_filename,
 graphics_filename
 +from sage.misc.temporary_file import tmp_dir, tmp_filename
  import plot
  import sage.misc.misc
  import sage.misc.viewer
 @@ -601,7 +601,7 @@ www.ffmpeg.org, or use 'convert' to produce gifs
 instead."""
                  raise OSError(msg)
          else:
              if not savefile:
 -                savefile = graphics_filename(ext='.gif')
 +                savefile = tmp_filename(ext='.gif')
              if not savefile.endswith('.gif'):
                  savefile += '.gif'
              savefile = os.path.abspath(savefile)
 @@ -812,7 +812,7 @@ please install it and try again."""
                  else:
                      if output_format[0] != '.':
                          output_format = '.'+output_format
 -                savefile = graphics_filename(ext=output_format)
 +                savefile = tmp_filename(ext=output_format)
              else:
                  if output_format is None:
                      suffix = os.path.splitext(savefile)[1]
 @@ -917,7 +917,7 @@ please install it and try again."""
          """
          pngdir = self.png()
          if savefile is None:
 -            savefile = graphics_filename('.png')
 +            savefile = tmp_filename('.png')
          with open(savefile, "wb") as out:
              apng = APngAssembler(
                  out, len(self),
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/18637#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to