#6402: [with patch, needs review] Fix bugs + improve documentation for
overconvergent modular forms
---------------------------+------------------------------------------------
Reporter: davidloeffler | Owner: craigcitro
Type: defect | Status: new
Priority: major | Milestone: sage-4.1.2
Component: modular forms | Keywords:
Reviewer: | Author:
Merged: |
---------------------------+------------------------------------------------
Comment(by AlexGhitza):
Looks good, and the added documentation is really great.
I'm attaching a tiny referee patch fixing a few typos, and if you are ok
with it we can give this a positive review.
There is one small issue, which I leave up to you whether you want to fix
it or not: in the method {{{valuation_plot}}}, you added an optional
argument {{{rmax}}}, but the docstring says nothing about its role.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6402#comment:4>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
