#16064: Python 3 preparation: Handle basestring (Py2) vs. str (Py3)
-------------------------------------+-------------------------------------
       Reporter:  wluebbe            |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.8
      Component:  distribution       |   Resolution:
       Keywords:  python3            |    Merged in:
        Authors:  André Apitzsch     |    Reviewers:  Ralf Stephan
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/aapitzsch/16064_2                |  002892eb3e5ece1d1e1c440831cf03521c36ea66
   Dependencies:  #18492             |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by wluebbe):

 * status:  needs_review => needs_work


Comment:

 The patch looks fine. Testing is OK.

 But in {{{sage-6.8.beta3}}} there are still {{{basestring}}}s in {{{
 sage/quivers/algebra.py    }}} line 277 and in
 {{{sage/quivers/path_semigroup.py}}} lines 340 / 348. The are NOT present
 {{{sage-6.8.beta0}}} on which the patch is based. I haven't found out why.

 Can you base the patch on {{{sage-6.8.beta3}}} and change the 3 remaining
 {{{basestring}}}s. Then I would set the ticket to positive review.

--
Ticket URL: <http://trac.sagemath.org/ticket/16064#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to