#6779: [with patch, needs review] positive_integer_relations bug in
lattice_polytope
----------------------+-----------------------------------------------------
 Reporter:  novoselt  |       Owner:  mhampton  
     Type:  defect    |      Status:  new       
 Priority:  major     |   Milestone:  sage-4.1.2
Component:  geometry  |    Keywords:            
 Reviewer:            |      Author:            
   Merged:            |  
----------------------+-----------------------------------------------------
 Since gcd(3/2, 9/5) used to be 3/10, it was used in lattice_polytope
 functions for rescaling to primitive integral vectors in the given
 rational direction. This is no longer true and leads to bugs:
 {{{
 sage: p = ReflexivePolytope(2, 1)
 sage: lattice_polytope.positive_integer_relations(p.vertices())
 Traceback (most recent call last):
 ...
 TypeError: matrix has denominators so can't change to ZZ.
 }}}
 The patch adds a function integral_length and uses it instead of gcd:
 {{{
 sage: p = ReflexivePolytope(2, 1)
 sage: lattice_polytope.positive_integer_relations(p.vertices())
 [2 1 1]
 }}}

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6779>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to