#18645: Add some methods to CartanMatrix
-------------------------------------+-------------------------------------
Reporter: jonathan.judge | Owner: jonathan.judge
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.8
Component: combinatorics | Resolution:
Keywords: days65 | Merged in:
Authors: | Reviewers: Ben Salisbury
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jonathan.judge/add_some_methods_to_cartanmatrix|
77f1bf6eced4549e4ea433d1904f273f4057baac
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by bsalisbury1):
* cc: bump, khlee (added)
* reviewer: => Ben Salisbury
Comment:
Hi Jon,
Patch looks good, documentation looks good, and all tests passed.
{{{
----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------
Total time for all tests: 2285.1 seconds
cpu time: 12380.9 seconds
cumulative wall time: 17333.0 seconds
}}}
Some suggestions, though:
- Should the term {{{strict}}} in {{{is_hyperbolic}}} be changed to
{{{compact}}} to mesh with some current literature?
- Can you also add a method {{{is_Lorentzian}}}?
Best,
Ben
--
Ticket URL: <http://trac.sagemath.org/ticket/18645#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
