#18646: Explicitly say that arguments to Graph.plot() are forwarded
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  ncohen                 |       Status:  positive_review
           Type:         |    Milestone:  sage-6.8
  enhancement            |   Resolution:
       Priority:  major  |    Merged in:
      Component:  graph  |    Reviewers:  Jori Mäntysalo
  theory                 |  Work issues:
       Keywords:         |       Commit:
        Authors:         |  228ff6bd7077c14c365df19ad5fd5b24f10b93d9
  Nathann Cohen          |     Stopgaps:
Report Upstream:  N/A    |
         Branch:         |
  public/18646           |
   Dependencies:         |
-------------------------+-------------------------------------------------

Comment (by slabbe):

 I wanted to review this ticket this morning, but it is already positive
 review. I had one english comment. I don't understand the part "{{{to
 which they are forwarded.}}}" in

 {{{
             - This method supports any parameter accepted by
               :meth:`sage.plot.graphics.Graphics.show`, to which they are
               forwarded.
 }}}

 Because arguments are forwarded *from* show *to* plot not the converse. I
 would replace "to which" by "from which" or better erase completely "{{{to
 which they are forwarded.}}}" because the user don't care much about what
 is forwarded where.

 I let you guys decide if it is too late or not (maybe this ticket is
 already being merged).

--
Ticket URL: <http://trac.sagemath.org/ticket/18646#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to