#6614: [with patch, positive review] Remove jsMath from version control in the
Sage library.
---------------------------+------------------------------------------------
Reporter: mpatel | Owner: tba
Type: defect | Status: new
Priority: minor | Milestone: sage-4.1.2
Component: documentation | Keywords:
Reviewer: John Palmieri | Author: Mitesh Patel
Merged: |
---------------------------+------------------------------------------------
Changes (by newvalueoldvalue):
* reviewer: => John Palmieri
* milestone: => sage-4.1.2
* author: => Mitesh Patel
Comment:
Replying to [comment:3 mpatel]:
> Since Sphinx recursively copies the only the contents of the static
paths, jsMath no longer gets its own directory in `_static`. I've changed
`jsmath_path` to `'easy/load.js'`.
Also, since the jsMath files all begin with "jsMath", we don't have to
worry about name clashes (except, I suppose, the names of the
subdirectories of jsMath, but I hope this won't be an issue).
Anyway, it looks good to me. I did manually delete
{{{doc/common/static/jsmath}}}, and the documentation build correctly,
with or without the "--jsmath" switch, and jsMath was active when reading
docs off-line and on. The patch is large, but almost all of it consists
of deleting files in {{{doc/common/static/jsmath}}}; the only
"interesting" part is at the very beginning, the changes to {{{conf.py}}}.
The changes there look good, both the new stuff and tidying up the old
stuff (using {{{os.path.join}}} instead of "+", for example).
I hope I'm not missing anything, but I think it gets a positive review.
Apply only
[http://trac.sagemath.org/sage_trac/attachment/ticket/6614/trac_6614-jsmath_repo_v2.patch
trac_6614-jsmath_repo_v2.patch].
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6614#comment:7>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
