#18678: Implement convolution_product for HopfAlgebras
-------------------------------------+-------------------------------------
Reporter: alauve | Owner:
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-6.8
Component: categories | Resolution:
Keywords: days65, | Merged in:
convolution product | Reviewers:
Authors: alauve | Work issues:
Report Upstream: N/A | Commit:
Branch: | 58f409befffcd138a1c29caefe671a309be82408
u/alauve/implement_convolution_product_for_hopfalgebras| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by saliola):
Here are some comments summarizing the live review we did at Sage Days 65:
* The first argument `arg0` in `def method_name(arg0, ...):` should be
`self`; this is a Python coding convention (and not strictly necessary for
the code to work, but Sage coding conventions requires this).
* Your documentation strings need to be formatted according to Sage coding
conventions. Here is a link to the relevant page in the Sage developer's
guide:[http://doc.sagemath.org/html/en/developer/coding_basics.html#the-
docstring-of-a-function-content The docstring of a function].
* You also need to add doctests (see the above link for details). Make
sure that all parts of your function are tested (i.e., if your code
handles various cases, then your doctests should test the various possible
cases).
* The function `n_fold_coproduct` defined within `convolution_power` is
interesting and should be a method on its own.
--
Ticket URL: <http://trac.sagemath.org/ticket/18678#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
