#18564: Boost Edge Connectivity
-------------------------------------+-------------------------------------
Reporter: borassi | Owner: borassi
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.8
Component: graph theory | Resolution:
Keywords: Boost, | Merged in:
connectivity | Reviewers:
Authors: Michele Borassi | Work issues:
Report Upstream: N/A | Commit:
Branch: | 7481889e9795e22c5d7ea9b42335f14548c9c636
u/borassi/boost_edge_connectivity | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by borassi):
Hi (just to change ;-) )!
I have applied all your remarks, except the following:
> Awkward question: I have to admit that I am no big fan of the huge
> copy/paste... Since Cython extension classes do not support templating
but
> functions do, what about not having a `BoostGraph` struct instead of a
class?
> We could have two of these struct and many functions that apply to it,
each of
> which handles fused types. Thus, only one function instead of two, no
more
> copy/paste?... Please tell me how you feel about that.
Nice! I will try it and I will let you know the results (it might take a
while).
> A way to solve both problems is to *merge* commits together (a specific
case of history rewriting). You can do this with 'git rebase -i develop'
I have two problems with rebase:
* the work can be very long, because I didn't know it, and in several
commits I also did small modifications that will be difficult to
replicate.
* At the moment, git rebase does not work:
{{{
git rebase -i develop
error: could not apply de3440a... initial implementation of unicode art
When you have resolved this problem, run "git rebase --continue".
If you prefer to skip this patch, run "git rebase --skip" instead.
To check out the original branch and stop rebasing, run "git rebase
--abort".
Could not apply de3440ab223b0031d10e447d124c5f68cbb388cd... initial
implementation of unicode art
}}}
> !`if H.is_directed(): val.append(H.strongly_connected_components())`
shouldn't you be using a !`breadth_first_search` instead of a !`SCC`?
Could you check that now the SCC/BFS code is correct?
Thank you very much!
Michele
--
Ticket URL: <http://trac.sagemath.org/ticket/18564#comment:34>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
