#18485: Make function to generate *all* independent sets.
-------------------------------------+-------------------------------------
Reporter: Rudi | Owner: Rudi
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.8
Component: matroid theory | Resolution:
Keywords: | Merged in:
Authors: Rudi Pendavingh | Reviewers: Vincent Delecroix
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/Rudi/make_function_to_generate__all__independent_sets_|
c320a69cfa5f9ad663ea7c6556356f6049070f1b
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Still some non-technical comments:
- Why are you declaring your new functions as `cpdef` and not `def`? Will
they be called from Cython code?
- Now, there are two very similar functions in
`basis_exchange_matroid.pyx`: `independent_r_sets` and `independent_sets`.
Could you at least make a reference to each other (ideally in a `..
SEEALSO` section). Similarly in `matroid.pyx` you have `bases`,
`independent_r_sets`, ...
- (not necessarily for this ticket) The code in `independent_r_sets` and
`bases_count` is almost identical. Why not making `bases_count` more
general by allowing to count the cardinality of independent set and share
the code with `independent_r_sets`?
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/18485#comment:37>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
