#18643: Implement reverse row bumping for Tableaux
-------------------------------------+-------------------------------------
Reporter: j.levinson | Owner:
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-6.8
Component: combinatorics | Resolution:
Keywords: days65 | Merged in:
Authors: Jake Levinson | Reviewers:
Report Upstream: N/A | Work issues:
Branch: u/j.levinson | Commit:
/reverse-bumping | 46b5118e98cac9a54027e806798552ed15b0adee
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by alauve):
* status: needs_review => needs_work
* cc: aschilling, jpswanson (added)
Comment:
Thanks for implementing this. I have only minor comments (1&2), plus some
questions (3&4) for all cc'd.
Jake,
1. Have a look at the python conventions page
[[http://www.sagemath.org/documentation/html/en/developer/coding_basics.html
#python-code-style]], as there are a few (minor) violations. E.g., "''from
(r-1,c)''" should read "''from (r-1, c).''"
2. It might be nice to add "Schensted" or some such keyword in the one-
sentence-description of `reverse_bump()`'s docstring.
-----
All,
3. Does it make sense to implement an `is_semistandard()` method?
4. Should we move `.bump()` and `.reverse_bump()` to
`SemistandardTableaux` class? As defined, `.bump()` will produce
''something'' for any tableau ''T'', but it will not be the inverse of
`.reverse_bump()` unless ''T'' is semistandard. In the opposite direction,
`.reverse_bump()` assumes that ''T'' is semistandard. There is no inverse
to the map `.bump()` as presently defined. Regardless, in the code
{{{
#!python
if not (self.is_row_increasing(weak=True) and
self.is_column_increasing(weak=False)):
raise ValueError("Reverse bumping is only defined for semistandard
tableaux")
}}}
perhaps the error should be `TypeError` or `NotImplementedError`?
--
Ticket URL: <http://trac.sagemath.org/ticket/18643#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
