#18127: Optional package lrs-4.2b.p1.spkg needs updating
-------------------------------------+-------------------------------------
Reporter: yzh | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: packages: | Resolution:
optional | Merged in:
Keywords: lrs, redund | Reviewers: Nathann Cohen
Authors: Matthias Koeppe | Work issues:
Report Upstream: N/A | Commit:
Branch: | c0093899d9bff0cf263fbd61bd359d8f67f4b0c7
u/mkoeppe/optional_package_lrs_4_2b_p1_spkg_needs_updating| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by ncohen):
* reviewer: => Nathann Cohen
Comment:
Hello !
The package was installed correctly with this new branch, but several
doctests were breaking. There are leftovet 'lrs' in the code, which you
probably do not see if you have installed the former version of the 'lrs'
spkg on your computer. I fixed them in a commit at `public/18127`.
With this commit, the branch is (in my opinion) ready to go.
For those who are not in Cc of the mail exchange with the package's
author: he told us that his makefile was custom-made to work with
polymake, and that it had been tested on "several OS/architecture without
problem". The changes we make to their makefile are very simple:
- change harcoded paths to include SAGE_ROOT
- replace 'install' by 'cp'
About autotool: they see no point in doing it themselves, but they would
not mind such a contribution.
As this package has been optional for a long while now, I believe that we
can keep it as it is for the moment, and autotoolize it later if we need
it.
What about you, Jeroen?
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/18127#comment:32>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
