#11187: Implementation of finite reflection groups
-------------------------------------+-------------------------------------
Reporter: stumpc5 | Owner: tbd
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.8
Component: combinatorics | Resolution:
Keywords: reflection group, | Merged in:
days49, days 64.5 | Reviewers:
Authors: Christian Stump | Work issues:
Report Upstream: N/A | Commit:
Branch: | ef3cbe7303af54c2390e04404fb6a4c2623b9c3e
u/stumpc5/11187-new | Stopgaps:
Dependencies: #18620 |
-------------------------------------+-------------------------------------
Comment (by chapoton):
Hello Christian,
thanks for your hard work on this ticket. I have only had a quick look, so
trivial remarks:
* not yet 100% coverage, I think (I have seen a few methods without
examples)
* `TODO::` should be `.. TODO::`
* Could you please replace `Returns` by `Return` everywhere.
* Sometime the first line of the doc is made of two sentences. Please
separate them as:
{{{
Return something.
Something is very very important.
}}}
* Please try to keep the lines 80 characters long.
* Bad alignement of EXAMPLES:: in `distinguished_reflection`,
`distinguished_reflections`
* missing optional in `sage: W = CoxeterGroup(["A",4],
implementation="chevie")`
And you should aim to have a green light from the patchbot. So far, this
has '''never''' been the case.
--
Ticket URL: <http://trac.sagemath.org/ticket/11187#comment:86>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
