#18691: Trac #17572 breaks the installation of several R packages.
-------------------------------------+-------------------------------------
Reporter: charpent | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.8
Component: packages: | Resolution:
standard | Merged in:
Keywords: r-project | Reviewers:
Authors: charpent | Work issues:
Report Upstream: N/A | Commit:
Branch: | f11ac816ff496a20c3f82594925cbc979d795f80
u/charpent/trac__17572_breaks_the_installation_of_several_r_packages_|
Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by fbissey):
As is it should work but the creation of the file `$R_MAKEVARS_SITE` is
unnecessary as `R` checks that it exist (from
`SAGE_LOCAL/lib/R/bin/config)
{{{
if test "${site}" = "yes"; then
: ${R_MAKEVARS_SITE="${R_HOME}/etc${R_ARCH}/Makevars.site"}
if test -f "${R_MAKEVARS_SITE}"; then
makefiles="${makefiles} -f ${R_MAKEVARS_SITE}"
fi
fi
}}}
The existence of `$R_MAKEVARS_USER` however is not tested, only that the
variable is not empty, so populating it when we define it is a really good
idea.
On a separate remark on style you should quote both ` R_MAKEVARS_SITE` and
`R_MAKEVARS_USER` as they are paths that can potentially contain spaces.
--
Ticket URL: <http://trac.sagemath.org/ticket/18691#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
