#18660: Improve efficiency of minors() for BinaryMatroid, TernaryMatroid,
QuaternaryMatroid
-------------------------------------+-------------------------------------
Reporter: Rudi | Owner: Rudi
Type: task | Status: positive_review
Priority: major | Milestone: sage-6.8
Component: matroid theory | Resolution:
Keywords: | Merged in:
Authors: Rudi Pendavingh | Reviewers: Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/Rudi/improve_efficiency_of_minors___for_binarymatroid__ternarymatroid__quaternarymatroid|
a5fd2f59b7ad6a827e358bc294f560c6ad6309a8
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by Rudi):
* status: needs_review => positive_review
Comment:
Replying to [comment:10 tscrim]:
> LGTM. I'm slightly unhappy with the fact that it looks like a lot of
logic is duplicated across the multiple
`matrix_from_rows_and_columns_reordered`, but I don't see a way to really
combine the common logic. So positive review.
Thanks for the review.
--
Ticket URL: <http://trac.sagemath.org/ticket/18660#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
